Improve reloptions validation for partitioned tables using non-default AMs

Previously, when creating a partitioned table without an explicit
`USING` clause, the reloptions (such as minmax_columns) were validated
with the assumption that the default_table_access_method is either
'heap', 'ao_row', or 'ao_column'. This could incorrectly reject valid
reloptions intended for other table access methods like 'pax'.

This patch adjusts the validation logic in DefineRelation() so that
reloptions are only validated for partitioned tables if the default
AM is one of the known AMs that support reloptions validation. For
non-default AMs, reloptions are passed unvalidated to allow extensions
to handle them properly.

This change enables successful creation of partitioned tables using
`USING pax WITH (minmax_columns=...)` without validation errors, even
when `default_table_access_method` is set to 'pax'.

Author: yjhjstz

contrib/pax_storage/expected/ddl.out

@@ -89,3 +89,26 @@ select 1 from (select count(*) from gp_toolkit.gp_size_of_schema_disk) empty_out
 (1 row)
 
 drop table pt_pax;
+-- expect create ok 
+create table pax_test.partition_cow(c1 int, c2 bigint, c3 varchar, c4 text, c5 date, c6 float4, c7 float8, c8 numeric, c9 interval)
+partition by range(c1) (start(1) end(15000) every(5000))
+with (minmax_columns='c1,c2,c3,c4,c5,c6,c7,c8,c9');
+NOTICE:  Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 'c1' as the Apache Cloudberry data distribution key for this table.
+HINT:  The 'DISTRIBUTED BY' clause determines the distribution of data. Make sure column(s) chosen are the optimal data distribution key to minimize skew.
+-- expect create ok 
+create table pax_test.partition_cow_1(c1 int, c2 bigint, c3 varchar, c4 text, c5 date, c6 float4, c7 float8, c8 numeric, c9 interval)
+partition by range(c1) (start(1) end(15000) every(5000))
+using pax with (minmax_columns='c1,c2,c3,c4,c5,c6,c7,c8,c9');
+NOTICE:  Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 'c1' as the Apache Cloudberry data distribution key for this table.
+HINT:  The 'DISTRIBUTED BY' clause determines the distribution of data. Make sure column(s) chosen are the optimal data distribution key to minimize skew.
+set default_table_access_method = heap;
+-- expect create fail
+create table pax_test.partition_cow_2(c1 int, c2 bigint, c3 varchar, c4 text, c5 date, c6 float4, c7 float8, c8 numeric, c9 interval)
+partition by range(c1) (start(1) end(15000) every(5000))
+with (minmax_columns='c1,c2,c3,c4,c5,c6,c7,c8,c9');
+NOTICE:  Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 'c1' as the Apache Cloudberry data distribution key for this table.
+HINT:  The 'DISTRIBUTED BY' clause determines the distribution of data. Make sure column(s) chosen are the optimal data distribution key to minimize skew.
+ERROR:  unrecognized parameter "minmax_columns"
+set default_table_access_method = pax;
+drop table pax_test.partition_cow;
+drop table pax_test.partition_cow_1;

contrib/pax_storage/sql/ddl.sql

@@ -58,3 +58,21 @@ PARTITION BY RANGE (date)
 SELECT pg_catalog.pg_relation_size('pt_pax'::regclass);
 select 1 from (select count(*) from gp_toolkit.gp_size_of_schema_disk) empty_out;
 drop table pt_pax;
+
+-- expect create ok 
+create table pax_test.partition_cow(c1 int, c2 bigint, c3 varchar, c4 text, c5 date, c6 float4, c7 float8, c8 numeric, c9 interval)
+partition by range(c1) (start(1) end(15000) every(5000))
+with (minmax_columns='c1,c2,c3,c4,c5,c6,c7,c8,c9');
+-- expect create ok 
+create table pax_test.partition_cow_1(c1 int, c2 bigint, c3 varchar, c4 text, c5 date, c6 float4, c7 float8, c8 numeric, c9 interval)
+partition by range(c1) (start(1) end(15000) every(5000))
+using pax with (minmax_columns='c1,c2,c3,c4,c5,c6,c7,c8,c9');
+
+set default_table_access_method = heap;
+-- expect create fail
+create table pax_test.partition_cow_2(c1 int, c2 bigint, c3 varchar, c4 text, c5 date, c6 float4, c7 float8, c8 numeric, c9 interval)
+partition by range(c1) (start(1) end(15000) every(5000))
+with (minmax_columns='c1,c2,c3,c4,c5,c6,c7,c8,c9');
+set default_table_access_method = pax;
+drop table pax_test.partition_cow;
+drop table pax_test.partition_cow_1;

contrib/pax_storage/src/test/regress/input/partition_ddl.source

@@ -999,6 +999,7 @@ create table part_heap1(a int, b int) using heap with (fillfactor=70) partition
 select c.relname, am.amname, c.reloptions from pg_partition_tree('part_heap1') as t join pg_class c on (t.relid::oid = c.oid) left join pg_am am on (c.relam = am.oid);
 
 -- Test 3: Parent's reloptions are explicitly specified, and parent's AM is implicitly specified as heap
+set default_table_access_method = heap;
 create table part_heap2(a int, b int) with (fillfactor=70) partition by range(b) (partition p1 start(0) end(10) with(appendonly=true));
 select c.relname, am.amname, c.reloptions from pg_partition_tree('part_heap2') as t join pg_class c on (t.relid::oid = c.oid) left join pg_am am on (c.relam = am.oid);
 

contrib/pax_storage/src/test/regress/output/partition_ddl.source

@@ -2902,6 +2902,7 @@ select c.relname, am.amname, c.reloptions from pg_partition_tree('part_heap1') a
 (2 rows)
 
 -- Test 3: Parent's reloptions are explicitly specified, and parent's AM is implicitly specified as heap
+set default_table_access_method = heap;
 create table part_heap2(a int, b int) with (fillfactor=70) partition by range(b) (partition p1 start(0) end(10) with(appendonly=true));
 ERROR:  unrecognized parameter "fillfactor"
 select c.relname, am.amname, c.reloptions from pg_partition_tree('part_heap2') as t join pg_class c on (t.relid::oid = c.oid) left join pg_am am on (c.relam = am.oid);

src/backend/commands/tablecmds.c

@@ -970,7 +970,12 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,
 			if (OidIsValid(accessMethodId))
 				(void) table_reloptions_am(accessMethodId, reloptions, 'r', true);
 			else
-				(void) partitioned_table_reloptions(reloptions, true);
+			{
+				bool validate = !strcasecmp(default_table_access_method, DEFAULT_TABLE_ACCESS_METHOD) ||
+							  !strcasecmp(default_table_access_method, "AO_ROW") ||
+							  !strcasecmp(default_table_access_method, "AO_COLUMN");
+				(void) partitioned_table_reloptions(reloptions, validate);
+			}
 			break;
 		case RELKIND_RELATION:
 		case RELKIND_MATVIEW: