Merge pull request #1094 from ably/fix-sync-emit-signature

owenpearson · web-flow · commit 388ca306f819 · 2022-12-13T13:11:35.000Z
fix: use correct sync event signature in base Transport class
diff --git a/src/common/lib/transport/transport.ts b/src/common/lib/transport/transport.ts
@@ -156,7 +156,7 @@ abstract class Transport extends EventEmitter {
       case actions.SYNC:
         if (message.connectionId !== undefined) {
           /* a transport SYNC */
-          this.emit('sync', message.connectionId, message);
+          this.emit('sync', message.connectionId, message.connectionId);
           break;
         }
         /* otherwise it's a channel SYNC, so handle it in the channel */

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ abstract class Transport extends EventEmitter {`
`156`	`156`	`case actions.SYNC:`
`157`	`157`	`if (message.connectionId !== undefined) {`
`158`	`158`	`/* a transport SYNC */`
`159`		`- this.emit('sync', message.connectionId, message);`
	`159`	`+ this.emit('sync', message.connectionId, message.connectionId);`
`160`	`160`	`break;`
`161`	`161`	`}`
`162`	`162`	`/* otherwise it's a channel SYNC, so handle it in the channel */`