Error in condition of game.js

[upavloff]

The line 206 of game.js has a small mistake:

    if (this.x + r < x + w)  

The condition should be this.x - r < x + w ! It should be a minus since this.x is the middle of the bird's corpse and x+wis the end of the pipe; otherwise, the condition is false as soon as the pic of the bird goes past the pipe.

[Sukh767]

collisioned: function () { if (!pipe.pipes.length) return; let bird = this.animations[0].sprite; let x = pipe.pipes[0].x; let y = pipe.pipes[0].y; let r = bird.height / 4 + bird.width / 4; let roof = y + parseFloat(pipe.top.sprite.height); let floor = roof + pipe.gap; let w = parseFloat(pipe.top.sprite.width); if (this.x + r >= x && this.x - r < x + w) { if (this.y - r <= roof || this.y + r >= floor) { SFX.hit.play(); return true; } } else if (pipe.moved) { UI.score.curr++; SFX.score.play(); pipe.moved = false; } return false; },
Modified the pipe collision condition from this.x + r < x + w to this.x + r >= x && this.x - r < x + w
Added an explicit return false at the end of the method to handle cases where no collision occurs
Fixed a potential issue with the collision detection by checking both x-axis and y-axis conditions

The new condition ensures that:

The bird's right side (this.x + r) is past the pipe's left side (x)
The bird's left side (this.x - r) is before the pipe's right side (x + w)
The bird's vertical position is either above the roof or below the floor of the pipe

This modification should more accurately detect collisions between the bird and the pipes, addressing the issue you pointed out with the original implementation.