From adc481cdbaaac4503e89446ffc9b0961b8e2e96b Mon Sep 17 00:00:00 2001 From: Minha Kang <118591632+m2na7@users.noreply.github.com> Date: Mon, 1 Sep 2025 23:52:35 +0900 Subject: [PATCH] refactor(react-query): replace magic number with named constant in suspense timers --- packages/react-query/src/suspense.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/react-query/src/suspense.ts b/packages/react-query/src/suspense.ts index b5bb6677e2..414370ec29 100644 --- a/packages/react-query/src/suspense.ts +++ b/packages/react-query/src/suspense.ts @@ -24,9 +24,10 @@ export const ensureSuspenseTimers = ( if (defaultedOptions.suspense) { // Handle staleTime to ensure minimum 1000ms in Suspense mode // This prevents unnecessary refetching when components remount after suspending + const MIN_SUSPENSE_TIME_MS = 1000 const clamp = (value: number | 'static' | undefined) => - value === 'static' ? value : Math.max(value ?? 1000, 1000) + value === 'static' ? value : Math.max(value ?? MIN_SUSPENSE_TIME_MS, MIN_SUSPENSE_TIME_MS) const originalStaleTime = defaultedOptions.staleTime defaultedOptions.staleTime = @@ -35,7 +36,7 @@ export const ensureSuspenseTimers = ( : clamp(originalStaleTime) if (typeof defaultedOptions.gcTime === 'number') { - defaultedOptions.gcTime = Math.max(defaultedOptions.gcTime, 1000) + defaultedOptions.gcTime = Math.max(defaultedOptions.gcTime, MIN_SUSPENSE_TIME_MS) } } }