fix ut

Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>

Author: silverbullet233

be/src/exec/hash_joiner.cpp

@@ -528,12 +528,8 @@ Status HashJoiner::_process_other_conjunct(ChunkPtr* chunk, JoinHashTable& hash_
 
 Status HashJoiner::_process_where_conjunct(ChunkPtr* chunk) {
     SCOPED_TIMER(probe_metrics().where_conjunct_evaluate_timer);
-    if (!_common_expr_ctxs.empty()) {
-        for (auto& [slot_id, ctx] : _common_expr_ctxs) {
-            ASSIGN_OR_RETURN(ColumnPtr column, ctx->evaluate((*chunk).get()))
-            (*chunk)->append_column(column, slot_id);
-        }
-    }
+    CommonExprEvalScopeGuard guard(*chunk, _common_expr_ctxs);
+    RETURN_IF_ERROR(guard.evaluate());
     return ExecNode::eval_conjuncts(_conjunct_ctxs, (*chunk).get());
 }
 

be/src/exec/pipeline/nljoin/nljoin_probe_operator.cpp

@@ -298,13 +298,6 @@ void NLJoinProbeOperator::iterate_enumerate_chunk(const ChunkPtr& chunk,
         call(false, 0, chunk->num_rows());
     }
 }
-Status NLJoinProbeOperator::_eval_common_exprs(const ChunkPtr& chunk) {
-    for (const auto& [slot_id, ctx] : _common_expr_ctxs) {
-        ASSIGN_OR_RETURN(ColumnPtr column, ctx->evaluate(chunk.get()));
-        chunk->append_column(std::move(column), slot_id);
-    }
-    return Status::OK();
-}
 
 Status NLJoinProbeOperator::_eval_nullaware_anti_conjuncts(const ChunkPtr& chunk, FilterPtr* filter) {
     if (!_join_conjuncts.empty() && chunk && !chunk->is_empty()) {

be/src/exec/pipeline/nljoin/nljoin_probe_operator.h

@@ -106,7 +106,6 @@ class NLJoinProbeOperator final : public OperatorWithDependency {
     bool _is_left_semi_join() const;
     bool _is_left_anti_join() const;
     bool _is_null_aware_left_anti_join() const;
-    Status _eval_common_exprs(const ChunkPtr& chunk);
 
 private:
     const TJoinOp::type _join_op;

be/src/storage/chunk_helper.h

@@ -222,6 +222,18 @@ class SegmentedChunk final : public std::enable_shared_from_this<SegmentedChunk>
 };
 
 class ExprContext;
+/**
+ * RAII guard for evaluating common expressions on a chunk.
+ * 
+ * This class provides automatic scope management for evaluating common expressions
+ * that are temporarily used during expression computation. Common expressions are
+ * computed once and reused across multiple expressions to avoid redundant computation,
+ * but they are only needed during the computation phase and should be cleaned up
+ * from the chunk after computation completes.
+ * 
+ * The destructor automatically removes the common expressions from the chunk
+ * to prevent memory leaks and ensure proper cleanup.
+ */
 class CommonExprEvalScopeGuard {
 public:
     CommonExprEvalScopeGuard(const ChunkPtr& chunk, const std::map<SlotId, ExprContext*>& common_expr_ctxs);

fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java

@@ -3712,8 +3712,11 @@ private JoinExprInfo buildJoinExpr(OptExpression optExpr, ExecPlan context) {
             List<Expr> otherJoinConjuncts = otherJoin.stream().map(e -> ScalarOperatorToExpr.buildExecExpression(e,
                             new ScalarOperatorToExpr.FormatterContext(context.getColRefToExpr())))
                     .collect(Collectors.toList());
-            PhysicalJoinOperator joinOperator = (PhysicalJoinOperator) optExpr.getOp();
-            Map<SlotId, Expr> commonSubExprMap = buildCommonSubExprMap(joinOperator.getPredicateCommonOperators(), context);
+            Map<SlotId, Expr> commonSubExprMap = Maps.newHashMap();
+            if (optExpr.getOp() instanceof PhysicalJoinOperator) {
+                PhysicalJoinOperator joinOperator = (PhysicalJoinOperator) optExpr.getOp();
+                commonSubExprMap = buildCommonSubExprMap(joinOperator.getPredicateCommonOperators(), context);
+            }
 
             List<ScalarOperator> predicates = Utils.extractConjuncts(predicate);
             List<Expr> conjuncts = predicates.stream().map(e -> ScalarOperatorToExpr.buildExecExpression(e,

fe/fe-core/src/test/java/com/starrocks/planner/PushDownSubfieldHashJoinTest.java

@@ -16,6 +16,8 @@
 
 import com.starrocks.common.FeConstants;
 import com.starrocks.qe.ConnectContext;
+import com.starrocks.sql.plan.PlanTestBase;
+import com.starrocks.sql.plan.PlanTestNoneDBBase;
 import com.starrocks.statistic.StatsConstants;
 import com.starrocks.utframe.StarRocksAssert;
 import com.starrocks.utframe.UtFrameUtils;
@@ -111,9 +113,15 @@ public void test() throws Exception {
                 "  |  colocate: false, reason: \n" +
                 "  |  equal join conjunct: 3: fk = 1: fk\n" +
                 "  |  other predicates: CAST(array_sum(array_map(<slot 8> -> <slot 8> != 'A', " +
-                "if(array_length(array_filter(['A','B'], CAST([0,CAST((2: col_int = 1) AND " +
-                "(4: id IS NOT NULL) AS TINYINT)] AS ARRAY<BOOLEAN>))) = 0, ['C'], " +
-                "array_filter(['A','B'], CAST([0,CAST((2: col_int = 1) AND (4: id IS NOT NULL) AS TINYINT)] " +
-                "AS ARRAY<BOOLEAN>))))) AS BOOLEAN)"));
+                "if(array_length(26: array_filter) = 0, ['C'], 26: array_filter))) AS BOOLEAN)\n" +
+                "  |    common sub expr:\n" +
+                "  |    <slot 20> : 2: col_int = 1\n" +
+                "  |    <slot 21> : 4: id IS NOT NULL\n" +
+                "  |    <slot 22> : (20: expr) AND (21: expr)\n" +
+                "  |    <slot 23> : CAST(22: expr AS TINYINT)\n" +
+                "  |    <slot 24> : [0,CAST((2: col_int = 1) AND (4: id IS NOT NULL) AS TINYINT)]\n" +
+                "  |    <slot 25> : CAST([0,CAST((2: col_int = 1) AND (4: id IS NOT NULL) AS TINYINT)] AS ARRAY<BOOLEAN>)\n" +
+                "  |    <slot 26> : array_filter(['A','B'], 25: cast)"));
+
     }
 }

fe/fe-core/src/test/java/com/starrocks/sql/plan/LowCardinalityTest.java

@@ -811,10 +811,11 @@ public void testProject() throws Exception {
         // test input two string column
         sql = "select if(S_ADDRESS='kks', S_COMMENT, S_COMMENT) from supplier";
         plan = getVerboseExplain(sql);
-        Assertions.assertTrue(plan.contains(
-                "9 <-> if[(DictDecode(10: S_ADDRESS, [<place-holder> = 'kks']), DictDecode(11: S_COMMENT, [<place-holder>]), " +
-                        "DictDecode(11: S_COMMENT, [<place-holder>])); args: BOOLEAN,VARCHAR,VARCHAR; " +
-                        "result: VARCHAR; args nullable: true; result nullable: true]"));
+        assertContains(plan, "  |  9 <-> if[(DictDecode(10: S_ADDRESS, [<place-holder> = 'kks']), " +
+                "[12: expr, VARCHAR(101), true], [12: expr, VARCHAR(101), true]); " +
+                "args: BOOLEAN,VARCHAR,VARCHAR; result: VARCHAR; args nullable: true; result nullable: true]\n" +
+                "  |  common expressions:\n" +
+                "  |  12 <-> DictDecode(11: S_COMMENT, [<place-holder>])");
         assertNotContains(plan, "DecodeNode");
 
         // common expression reuse 3
@@ -825,7 +826,10 @@ public void testProject() throws Exception {
         // support(support(unsupport(Column), unsupport(Column)))
         sql = "select REVERSE(SUBSTR(LEFT(REVERSE(S_ADDRESS),INSTR(REVERSE(S_ADDRESS),'/')-1),5)) FROM supplier";
         plan = getFragmentPlan(sql);
-        assertContains(plan, "<slot 9> : reverse(substr(left(DictDecode(10: S_ADDRESS, [reverse(<place-holder>)])");
+        assertContains(plan, "  |  <slot 9> : " +
+                "reverse(substr(left(11: expr, CAST(CAST(instr(11: expr, '/') AS BIGINT) - 1 AS INT)), 5))\n" +
+                "  |  common expressions:\n" +
+                "  |  <slot 11> : DictDecode(10: S_ADDRESS, [reverse(<place-holder>)])");
     }
 
     @Test

fe/fe-core/src/test/java/com/starrocks/sql/plan/LowCardinalityTest2.java

@@ -923,7 +923,10 @@ public void testProject() throws Exception {
         // support(support(unsupport(Column), unsupport(Column)))
         sql = "select REVERSE(SUBSTR(LEFT(REVERSE(S_ADDRESS),INSTR(REVERSE(S_ADDRESS),'/')-1),5)) FROM supplier";
         plan = getFragmentPlan(sql);
-        assertContains(plan, "<slot 9> : reverse(substr(left(DictDecode(10: S_ADDRESS, [reverse(<place-holder>)])");
+        assertContains(plan, "  |  <slot 9> : reverse(substr(left(11: expr, " +
+                "CAST(CAST(instr(11: expr, '/') AS BIGINT) - 1 AS INT)), 5))\n" +
+                "  |  common expressions:\n" +
+                "  |  <slot 11> : DictDecode(10: S_ADDRESS, [reverse(<place-holder>)])");
     }
 
     @Test