Fix safe encoding for passwords with exclamation mark (#93)

hemker · Dennis Hemker · web-flow · commit 336af8e0308b · 2025-06-19T09:47:29.000Z
Co-authored-by: Dennis Hemker &lt;dennis.hemker@fit.fraunhofer.de&gt;
diff --git a/reolinkapi/mixins/stream.py b/reolinkapi/mixins/stream.py
@@ -40,7 +40,7 @@ def get_snap(self, timeout: float = 3, proxies: Any = None) -> Optional[Image]:
                 'user': self.username,
                 'password': self.password,
             }
-            parms = parse.urlencode(data).encode("utf-8")
+            parms = parse.urlencode(data, safe="!").encode("utf-8")
 
             try:
                 response = requests.get(self.url, proxies=proxies, params=parms, timeout=timeout)

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ def get_snap(self, timeout: float = 3, proxies: Any = None) -> Optional[Image]:`
`40`	`40`	`'user': self.username,`
`41`	`41`	`'password': self.password,`
`42`	`42`	`}`
`43`		`- parms = parse.urlencode(data).encode("utf-8")`
	`43`	`+ parms = parse.urlencode(data, safe="!").encode("utf-8")`
`44`	`44`
`45`	`45`	`try:`
`46`	`46`	`response = requests.get(self.url, proxies=proxies, params=parms, timeout=timeout)`