Dedicated Struct for Item + Sender-Randomness + Reciever-Preimage

[aszepieniec]

A very strong pattern throughout the codebase is a triple of Digests labeled "item", "sender_randomness", and "receiver_preimage". Let's dedicate a struct to this triple so that we can reuse code, make use of natural From-casts, and structured proptests.

Hat-tip-to: @skaunov

[dan-da]

related: I maintain that we should be using newtypes for different Digest usages so the compiler enforces correct usage. #196 makes a start at this.

iirc, there is not consensus about this though.

[aszepieniec]

Commit e522fb8 introduces this dedicated struct. As I recall it was implemented out of necessity for the redemption procedure but before the redeem <-> reboot split, meaning that it was integrated into both branches and eventually made it to master.

[skaunov]

Could you point it out explicitly, pls. Search for " struct" didn't succeed, I don't remember this PR that well, it's big, and I'm on a run a bit. I'm asking to see if that `struct Randomness` from the tests could be adjoined to this one. For example as a concrete instantiation of the generic.

…

On Вс, авг 10 2025 at 03:20:28 -0700, aszepieniec ***@***.***> wrote: *aszepieniec* left a comment (Neptune-Crypto/neptune-core#546) <#546 (comment)> Commit e522fb8 <e522fb8> introduces this dedicated struct. As I recall it was implemented out of necessity for the redemption procedure but before the redeem <-> reboot split, meaning that it was integrated into both branches and eventually made it to master. — Reply to this email directly, view it on GitHub <#546 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APXLOTZWT7XZZIQIQLFBMW33M4MGZAVCNFSM6AAAAAB2VRPU6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNZSGUZDMNRSGQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[aszepieniec]

It now lives in neptune-core/src/models/blockchain/transaction/utxo_triple.rs. The struct name is UtxoTriple.

[aszepieniec]

I'm asking to see if that struct Randomness from the tests could be adjoined to this one. For example as a concrete instantiation of the generic.

My guess is "probably yes" but I'm sure you can figure out a more definite answer once you see it.

[skaunov]

Thank you! Took a look. I'd say currently there will be no benefit in interleaving those, but if there will be more similar structures (carrying randomness for the code clarity) it'd be nice to uniform those with that structure from the tests so it'd be using thing like `Randomness<2, 0>`.

…

On Вс, авг 10 2025 at 03:36:32 -0700, aszepieniec ***@***.***> wrote: *aszepieniec* left a comment (Neptune-Crypto/neptune-core#546) <#546 (comment)> > I'm asking to see if that struct Randomness from the tests could be > adjoined to this one. For example as a concrete instantiation of the > generic. > My guess is "probably yes" but I'm sure you can figure out a more definite answer once you see it. — Reply to this email directly, view it on GitHub <#546 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APXLOT2SW7ZFGM5MGAQA2733M4ODBAVCNFSM6AAAAAB2VRPU6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNZSGUZTIMJQHE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[skaunov]

Even extending to a trait actually to avoid any confusion of the fields.