fix: safeguards on dictionary adapter dealloc

Author: edusperoni

NativeScript/runtime/DictionaryAdapter.mm

@@ -158,14 +158,15 @@ - (void)dealloc {
 @implementation DictionaryAdapter {
     IsolateWrapper* wrapper_;
     std::shared_ptr<Persistent<Value>> object_;
+    ObjCDataWrapper* dataWrapper_;
 }
 
 - (instancetype)initWithJSObject:(Local<Object>)jsObject isolate:(Isolate*)isolate {
     if (self) {
         self->wrapper_ = new IsolateWrapper(isolate);
         self->object_ = std::make_shared<Persistent<Value>>(isolate, jsObject);
         self->wrapper_->GetCache()->Instances.emplace(self, self->object_);
-        tns::SetValue(isolate, jsObject, new ObjCDataWrapper(self));
+        tns::SetValue(isolate, jsObject, (self->dataWrapper_ = new ObjCDataWrapper(self)));
     }
 
     return self;
@@ -253,17 +254,25 @@ - (NSEnumerator*)keyEnumerator {
 }
 
 - (void)dealloc {
-    if(wrapper_->IsValid()) {
+    if (wrapper_->IsValid()) {
         Isolate* isolate = wrapper_->Isolate();
+        v8::Locker locker(isolate);
+        Isolate::Scope isolate_scope(isolate);
+        HandleScope handle_scope(isolate);
         wrapper_->GetCache()->Instances.erase(self);
         Local<Value> value = self->object_->Get(isolate);
         BaseDataWrapper* wrapper = tns::GetValue(isolate, value);
         if (wrapper != nullptr) {
+            if (wrapper == dataWrapper_) {
+                dataWrapper_ = nullptr;
+            }
             tns::DeleteValue(isolate, value);
             delete wrapper;
         }
     }
-    self->object_ = nil;
+    if (dataWrapper_ != nullptr) {
+        delete dataWrapper_;
+    }
     self->object_ = nullptr;
     delete self->wrapper_;