Skip to content

Commit 7015b22

Browse files
committed
debug: check base and merge commit results (3)
1 parent d31de80 commit 7015b22

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

.github/workflows/benchmark-pr.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ jobs:
3131
BASE_COMMIT_HASH: ${{ github.event.pull_request.base.sha }}
3232
GITHUB_SHA: ${{ github.event.pull_request.head.sha }}
3333
MERGE_BASE_COMMIT_HASH: '' # placeholder so that we have autocomplete and logs
34+
3435
steps:
3536
- name: Checkout and setup environment
3637
uses: MetaMask/action-checkout-and-setup@v1
@@ -61,11 +62,7 @@ jobs:
6162
if: ${{ github.event_name == 'pull_request' }}
6263
run: yarn tsx development/benchmark-pr-comment.ts
6364
env:
64-
PR_COMMENT_TOKEN: ${{ secrets.PR_COMMENT_TOKEN }}
65-
OWNER: ${{ github.repository_owner }}
66-
REPOSITORY: ${{ github.event.repository.name }}
6765
PR_NUMBER: ${{ github.event.pull_request.number }}
68-
GITHUB_SHA: ${{ github.event.pull_request.head.sha }}
6966

7067
- name: Upload benchmark results
7168
if: github.ref == 'refs/heads/main'

development/benchmark-pr-comment.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,6 @@ async function fetchLatestMainBenchmarkData(
180180

181181
// Take the latest N commits (or all if less than N)
182182
const latestCommits = commitHashes.slice(0, n);
183-
console.log(
184-
`Processing ${latestCommits.length} commits: ${latestCommits.join(', ')}`,
185-
);
186-
187183
return aggregateHistoricalBenchmarkData(latestCommits, data, n);
188184
} catch (error) {
189185
console.warn('Error fetching historical benchmark data:', error);
@@ -530,7 +526,7 @@ function generateBenchmarkComment(
530526
* - OWNER: Repository owner (ex.: "MetaMask")
531527
* - REPOSITORY: Repository name (ex.: "metamask-extension")
532528
* - PR_NUMBER: Pull request number to comment on
533-
* - GITHUB_SHA: Head commitSha
529+
* - GITHUB_SHA: Head commit hash
534530
*
535531
* @throws {Error} When GitHub API request fails or required environment variables are missing.
536532
*/

0 commit comments

Comments
 (0)