build: commit hash parameter from Compare and comment step in Page Load Benchmark workflow (#35554)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

The "Compare and comment" step in the page load benchmark workflow is
currently posting comments with the wrong commit hash. This occurs
because:

- **Workflow Architecture Issue**: The `benchmark-pr.yml` is a
`workflow_call` workflow that gets called by `main.yml`
- **Context Variable Mismatch**: When a workflow is called by another
workflow, `github.sha` refers to the commit that triggered the calling
workflow (`main.yml`), not necessarily the latest commit on the PR
branch
- **Stale Commit Reference**: This results in the benchmark comment
showing an outdated commit hash instead of the actual commit being
benchmarked

The "Upload benchmark results step" is **_NOT affected_**, as this step
correctly uses the proper commit hash when the PR is merged to `main` ,
as it runs in the context of the `main` branch workflow.

This PR separates and calls the workflow for page load benchmark comment
at a point we are sure the commit hash parameter from the "Compare and
comment" step is the correct one.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/35554?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-692

## **Manual testing steps**

1. No user facing changes, so no testing steps required.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="990" height="950" alt="Screenshot 2025-09-06 at 16 25 30"
src="https://github.com/user-attachments/assets/356d35d9-abf3-479b-ac60-0921ac30e2f2"
/>

<!-- [screenshots/recordings] -->

### **After**

<img width="1033" height="961" alt="Screenshot 2025-09-06 at 16 25 43"
src="https://github.com/user-attachments/assets/732e9eb0-6337-4587-8346-251fcce45f1b"
/>

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: ffmcgee725

.github/actions/page-load-benchmark-comment/action.yml

@@ -0,0 +1,32 @@
+name: 'Page load benchmark comment'
+description: 'Download benchmark results, create directory structure, and comment on PR'
+inputs:
+  head-commit-hash:
+    description: 'The head commit hash to pass to the benchmark comment script'
+    required: true
+  pr-comment-token:
+    description: 'GitHub token for commenting on PR'
+    required: true
+runs:
+  using: 'composite'
+  steps:
+    - name: Download page load benchmark results
+      uses: actions/download-artifact@v4
+      with:
+        name: benchmark-results
+
+    - name: Create expected page load benchmark results directory structure
+      shell: bash
+      run: |
+        mkdir -p test-artifacts/benchmarks
+        mv benchmark-results.json test-artifacts/benchmarks/benchmark-results.json
+
+    - name: Page load benchmark compare and comment
+      shell: bash
+      run: yarn tsx development/page-load-benchmark-pr-comment.ts
+      env:
+        PR_COMMENT_TOKEN: ${{ inputs.pr-comment-token }}
+        OWNER: ${{ github.repository_owner }}
+        REPOSITORY: ${{ github.event.repository.name }}
+        PR_NUMBER: ${{ github.event.pull_request.number }}
+        HEAD_COMMIT_HASH: ${{ inputs.head-commit-hash }}

.github/workflows/main.yml

@@ -240,11 +240,11 @@ jobs:
           s3-bucket: ${{ vars.AWS_S3_BUCKET }}/${{ github.event.repository.name }}/${{ github.run_id }}/bundle-size
           path: test-artifacts/chrome
 
-  benchmark-pr:
+  page-load-benchmark-pr:
     needs:
       - build-dist-browserify
     if: ${{ github.event_name == 'pull_request' || (github.event_name == 'push' && github.ref_name == 'main') }}
-    uses: ./.github/workflows/benchmark-pr.yml
+    uses: ./.github/workflows/page-load-benchmark-pr.yml
     with:
       browser-loads: '10'
       page-loads: '10'

.github/workflows/benchmark-pr.yml renamed to .github/workflows/page-load-benchmark-pr.yml

@@ -1,4 +1,4 @@
-name: Benchmark PR Performance
+name: Page load benchmark
 
 on:
   workflow_call:
@@ -20,7 +20,7 @@ on:
         required: true
 
 jobs:
-  benchmark-pr:
+  page-load-benchmark-pr:
     name: Run Page Load Benchmarks
     runs-on: ubuntu-latest
     env:
@@ -48,17 +48,13 @@ jobs:
       - name: Run page load benchmarks
         run: yarn test:e2e:benchmark
 
-      - name: Compare and comment
-        if: ${{ github.event_name == 'pull_request' }}
-        run: yarn tsx development/benchmark-pr-comment.ts
-        env:
-          PR_COMMENT_TOKEN: ${{ secrets.PR_COMMENT_TOKEN }}
-          OWNER: ${{ github.repository_owner }}
-          REPOSITORY: ${{ github.event.repository.name }}
-          PR_NUMBER: ${{ github.event.pull_request.number }}
-          GITHUB_SHA: ${{ github.event.pull_request.head.sha }}
+      - name: Upload benchmark results (github artifacts)
+        uses: actions/upload-artifact@v4
+        with:
+          name: benchmark-results
+          path: test-artifacts/benchmarks/benchmark-results.json
 
-      - name: Upload benchmark results
+      - name: Upload benchmark results (historical data)
         if: github.ref == 'refs/heads/main'
         run: .github/scripts/benchmark-stats-commit.sh
         env:

.github/workflows/publish-prerelease.yml

@@ -60,6 +60,13 @@ jobs:
           echo "MERGE_BASE_COMMIT_HASH=${merge_base_commit_hash}" >> "${GITHUB_ENV}"
           echo "The merge base commit hash is '${merge_base_commit_hash}'"
 
+      - name: Page load benchmark comment
+        if: ${{ github.event_name == 'pull_request' }}
+        uses: ./.github/actions/page-load-benchmark-comment
+        with:
+          head-commit-hash: ${{ env.HEAD_COMMIT_HASH }}
+          pr-comment-token: ${{ secrets.PR_COMMENT_TOKEN }}
+
       - name: Publish prerelease
         if: ${{ env.MERGE_BASE_COMMIT_HASH && env.PR_NUMBER && env.PR_COMMENT_TOKEN && vars.AWS_CLOUDFRONT_URL }}
         run: yarn tsx ./development/metamaskbot-build-announce.ts

development/benchmark-pr-comment.ts renamed to development/page-load-benchmark-pr-comment.ts

@@ -534,7 +534,7 @@ function generateBenchmarkComment(
  * @throws {Error} When GitHub API request fails or required environment variables are missing
  */
 async function main(): Promise<void> {
-  const { PR_COMMENT_TOKEN, OWNER, REPOSITORY, PR_NUMBER } =
+  const { PR_COMMENT_TOKEN, OWNER, REPOSITORY, PR_NUMBER, HEAD_COMMIT_HASH } =
     process.env as Record<string, string>;
   const N_COMMITS = 10;
 
@@ -568,6 +568,7 @@ async function main(): Promise<void> {
     return;
   }
 
+  benchmarkData.commit = HEAD_COMMIT_HASH;
   const referenceData = await fetchLatestMainBenchmarkData(N_COMMITS);
 
   const commentBody = generateBenchmarkComment(benchmarkData, referenceData);