fix more warnings

Author: jackkav

eslint.config.mjs

@@ -57,11 +57,11 @@ export default tseslint.config(
     rules: {
       ...playwright.configs['flat/recommended'].rules,
       'playwright/expect-expect': 'off',
-      'playwright/valid-title': 'off', //TODO: avoid using looping e2e tests
       'playwright/require-soft-assertions': 'error',
       'playwright/prefer-native-locators': 'error',
       'playwright/prefer-to-be': 'error',
       'playwright/prefer-to-contain': 'error',
+      'playwright/no-wait-for-timeout': 'error',
     },
   },
   {

packages/insomnia-smoke-test/tests/smoke/insomnia-vault.test.ts

@@ -78,7 +78,7 @@ test.describe('Check vault used in environment', () => {
     },
   });
 
-  test('test global private sub environment to store vaults', async ({ page, app }) => {
+  test('global private sub environment to store vaults', async ({ page, app }) => {
     await page.getByTestId('settings-button').click();
     await page.getByTestId('dataFolders').fill(getFixturePath('vault-collection.yaml'));
     await page.getByTestId('dataFolders-btn').click();

packages/insomnia-smoke-test/tests/smoke/pre-request-script-features.test.ts

@@ -250,8 +250,8 @@ test.describe('pre-request features tests', () => {
 
     // enter script
     await page.getByRole('tab', { name: 'Scripts' }).click();
-    const preRequestScriptEditor = page.getByTestId('CodeEditor').getByRole('textbox');
-    await preRequestScriptEditor.fill(`
+    const editor = page.getByTestId('CodeEditor').getByRole('textbox');
+    await editor.fill(`
           const rawReq = {
               url: 'http://127.0.0.1:4010/echo',
               method: 'POST',
@@ -634,56 +634,40 @@ test.describe('unhappy paths', () => {
     await page.getByLabel('Pre-request Scripts').click();
   });
 
-  const testCases = [
-    {
-      name: 'custom error is returned',
-      preReqScript: `
-            throw Error('my custom error');
-            `,
-      context: {
-        insomnia: {},
-      },
-      expectedResult: {
-        message: 'my custom error',
-      },
-    },
-    {
-      name: 'syntax error',
-      preReqScript: `
-            insomnia.INVALID_FIELD.set('', '')
-            `,
-      context: {
-        insomnia: {},
-      },
-      expectedResult: {
-        message: "Cannot read properties of undefined (reading 'set')",
-      },
-    },
-  ];
+  test('custom errors are returned', async ({ page }) => {
+    await page.getByLabel('Request Collection').getByTestId('echo pre-request script result').press('Enter');
+
+    // set request body
+    await page.getByRole('tab', { name: 'Body' }).click();
+    await page.getByRole('button', { name: 'Body' }).click();
+    await page.getByRole('option', { name: 'JSON' }).click();
+
+    // enter script
+    await page.getByRole('tab', { name: 'Scripts' }).click();
+    const editor = page.getByTestId('CodeEditor').getByRole('textbox');
+    await editor.fill(`throw Error('my custom error');`);
 
-  for (const tc of testCases) {
-    test(tc.name, async ({ page }) => {
-      const responsePane = page.getByTestId('response-pane');
+    await page.getByRole('tab', { name: 'Body' }).click();
 
-      await page.getByLabel('Request Collection').getByTestId('echo pre-request script result').press('Enter');
+    // send
+    await page.getByTestId('request-pane').getByRole('button', { name: 'Send' }).click();
 
-      // set request body
-      await page.getByRole('tab', { name: 'Body' }).click();
-      await page.getByRole('button', { name: 'Body' }).click();
-      await page.getByRole('option', { name: 'JSON' }).click();
+    // verify
+    await expect.soft(page.getByTestId('response-pane')).toContainText('my custom error');
 
-      // enter script
-      await page.getByRole('tab', { name: 'Scripts' }).click();
-      const preRequestScriptEditor = page.getByTestId('CodeEditor').getByRole('textbox');
-      await preRequestScriptEditor.fill(tc.preReqScript);
+    await page.getByRole('tab', { name: 'Scripts' }).click();
+    await page.getByTestId('CodeEditor').getByRole('textbox').press('ControlOrMeta+a');
+    await page.keyboard.press('Backspace');
+    await editor.fill(`insomnia.INVALID_FIELD.set('', '')`);
 
-      await page.getByRole('tab', { name: 'Body' }).click();
+    await page.getByRole('tab', { name: 'Body' }).click();
 
-      // send
-      await page.getByTestId('request-pane').getByRole('button', { name: 'Send' }).click();
+    // send
+    await page.getByTestId('request-pane').getByRole('button', { name: 'Send' }).click();
 
-      // verify
-      await expect.soft(responsePane).toContainText(tc.expectedResult.message);
-    });
-  }
+    // verify
+    await expect
+      .soft(page.getByTestId('response-pane'))
+      .toContainText(`Cannot read properties of undefined (reading 'set')`);
+  });
 });