From b4c6c7bf70f0f3410a2a4bb14e887a1533bf1af0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Davy=20H=C3=A9lard?= Date: Mon, 7 Jul 2025 18:33:03 +0200 Subject: [PATCH 1/2] [Reviewed] [3D particles] Fix the rotation around X axis to be the other way --- extensions/reviewed/ParticleEmitter3D.json | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/extensions/reviewed/ParticleEmitter3D.json b/extensions/reviewed/ParticleEmitter3D.json index 090394b15..2459bf879 100644 --- a/extensions/reviewed/ParticleEmitter3D.json +++ b/extensions/reviewed/ParticleEmitter3D.json @@ -9,7 +9,7 @@ "name": "ParticleEmitter3D", "previewIconUrl": "https://asset-resources.gdevelop.io/public-resources/Icons/f2e5a34bf465f781866677762d385d6c8e9e8d203383f2df9a3b7e0fad6a2cb5_fire.svg", "shortDescription": "Display a large number of particles in 3D to create visual effects in a 3D game.", - "version": "2.2.0", + "version": "3.0.0", "description": [ "3D particle emitters let you create and display many small particles to simulate visual effects in your game — like fire, explosions, smoke, or dust.", "", @@ -34,6 +34,10 @@ "IWykYNRvhCZBN3vEgKEbBPOR3Oc2" ], "changelog": [ + { + "version": "3.0.0", + "breaking": "- the object rotate the other way around X axis." + }, { "version": "2.0.0", "breaking": "- Object properties for position and rotation have been removed. They must be set with the instance editor or the action." @@ -77,9 +81,7 @@ " const threeObject3D = this.get3DRendererObject();", "", " threeObject3D.rotation.set(", - " // TODO The rotation on X goes the wrong way.", - " // Increment the major and remove this sign.", - " - gdjs.toRad(this._object.getRotationX()),", + " gdjs.toRad(this._object.getRotationX()),", " gdjs.toRad(this._object.getRotationY()),", " gdjs.toRad(this._object.angle)", " );", From 1e7a7163c86f4a6266df7268c0c36474388610b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Davy=20H=C3=A9lard?= Date: Thu, 11 Sep 2025 18:55:53 +0200 Subject: [PATCH 2/2] Add a default size --- extensions/reviewed/ParticleEmitter3D.json | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/extensions/reviewed/ParticleEmitter3D.json b/extensions/reviewed/ParticleEmitter3D.json index 2459bf879..eaac26650 100644 --- a/extensions/reviewed/ParticleEmitter3D.json +++ b/extensions/reviewed/ParticleEmitter3D.json @@ -6995,6 +6995,15 @@ "", "/** @type {gdjs.CustomRuntimeObject} */", "const object = objects[0];", + "// Force the size of the object because it doesn't contain any instance.", + "object._innerArea = {", + " min: [-16, -16, -16],", + " max: [16, 16, 16],", + " };", + "const hitbox = new gdjs.Polygon();", + "hitbox.vertices = [[-16, -16], [16, -16], [16, 16], [-16, 16]];", + "object._untransformedHitBoxes = [hitbox];", + "object._updateUntransformedHitBoxes = () => {};", "", "// Here runtimeScene is the gdjs.CustomRuntimeObjectInstanceContainer inside the custom object.", "const gameScene = object.getRuntimeScene();",