Merge pull request #443 from futa-ikeda/fix-gravatar

[ENG-1504] Fix broken gravatar for logged out users

Author: fabmiz

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+### Fixed
+- `new-navbar-auth-dropdown` fixed for unauthenticated users
+
 ## [0.29.0] - 2020-03-25
 ### Changed
 - `hasDataLinks` and `hasPreregLinks` preprint fields to `string`

addon/components/new-navbar-auth-dropdown/template.hbs

@@ -1,4 +1,4 @@
-{{# if session.isAuthenticated }}
+{{#if session.isAuthenticated }}
     {{! TODO: Replace display name functionality if possible- for now truncate via CSS at end of label }}
     {{#bs-dropdown tagName='li' classNames="secondary-nav-dropdown" as |dd|}}
         {{#dd.toggle tagName="a" classNames="btn-link"}}

tests/integration/components/new-navbar-auth-dropdown/component-test.js

@@ -1,16 +1,41 @@
+import Ember from 'ember';
 import { moduleForComponent, test } from 'ember-qunit';
 import hbs from 'htmlbars-inline-precompile';
 
+
+// Session Stub No Auth
+const sessionStubUnauthenticated = Ember.Service.extend({
+  isAuthenticated: false
+});
+
+// Session Stub Auth
+const sessionStubAuthenticated = Ember.Service.extend({
+  isAuthenticated: true
+});
+
 moduleForComponent('new-navbar-auth-dropdown', 'Integration | Component | new navbar auth dropdown', {
-  integration: true
+  integration: true,
 });
 
-test('it renders', function (assert) {
-    // Set any properties with this.set('myProperty', 'value');
-    // Handle any actions with this.on('myAction', function(val) { ... });
+test('it renders when session is authenticated', function (assert) {
+  this.register('service:session', sessionStubAuthenticated);
+  this.set('loginAction', ()=>{});
+  this.render(hbs`{{new-navbar-auth-dropdown loginAction=loginAction}}`);
 
-    this.set('loginAction', ()=>{});
-    this.render(hbs`{{new-navbar-auth-dropdown loginAction=loginAction}}`);
+  assert.notOk(this.$('.btn-top-login').length, 'log in button does not exists for authenticated');
+  assert.notOk(this.$('.btn-top-signup').length, 'sign up button does not exists for authenticated');
+  assert.ok(this.$('.osf-profile-image').length, 'has gravatar for authenticated session');
+  assert.ok(this.$('.nav-profile-name').length, 'has username for authenticated session')
+  assert.notEqual(this.$().text().trim(), '');
+});
 
-    assert.notEqual(this.$().text().trim(), '');
+test('it renders when session is not authenticated', function (assert) {
+  this.register('service:session', sessionStubUnauthenticated);
+  this.set('loginAction', ()=>{});
+  this.render(hbs`{{new-navbar-auth-dropdown loginAction=loginAction}}`);
+  assert.ok(this.$('.btn-top-login').length, 'log in button exists for unauthenticated');
+  assert.ok(this.$('.btn-top-signup').length, 'sign up button exists for unauthenticated');
+  assert.notOk(this.$('.osf-profile-image').length, 'no gravatar for unauthenticated session');
+  assert.notOk(this.$('.nav-profile-name').length, 'no username for unauthenticated session')
+  assert.notEqual(this.$().text().trim(), '');
 });