Merge pull request #2702 from KachanovYev/bug/#2663-negating-run-properties-with-cli-arguments-not-working

[🐛 BUG] Negating run properties with CLI arguments not working

Author: trgiangdo

taipy/common/_cli/_run_cli.py

@@ -54,7 +54,17 @@ def handle_command(cls):
             external_args.extend(all_args[external_args_index + 1 :])
             all_args = all_args[:external_args_index]
 
-        taipy_args = [f"--taipy-{arg[2:]}" if arg.startswith("--") else arg for arg in all_args]
+        def add_taipy_prefix(key: str):
+            """
+            Adds the '--taipy-' prefix to command-line arguments starting with '--'.
+            If the argument starts with '--no-', inserts 'taipy-' after '--no-'.
+            Otherwise, inserts 'taipy-' after '--'.
+            """
+            if key.startswith("--no-"):
+                return key[:5] + "taipy-" + key[5:]
+            return key[:2] + "taipy-" + key[2:]
+
+        taipy_args = [add_taipy_prefix(arg) if arg.startswith("--") else arg for arg in all_args]
 
         try:
             subprocess.run(

tests/gui/config/test_cli.py

@@ -156,6 +156,84 @@ def test_gui_service_arguments_hierarchy():
         gui.stop()
 
 
+def test_cli_arguments_no_run_browser_and_no_reloader():
+    # Test --no-run-browser argument
+    with patch("sys.argv", ["prog", "--no-run-browser"]):
+        gui = Gui()
+        gui.run(run_server=False, run_browser=True)
+        service_config = gui._config.config
+        assert not service_config["run_browser"]
+        gui.stop()
+
+    # Test --no-reloader argument
+    with patch("sys.argv", ["prog", "--no-reloader"]):
+        gui = Gui()
+        gui.run(run_server=False, use_reloader=True)
+        service_config = gui._config.config
+        assert not service_config["use_reloader"]
+        gui.stop()
+
+    # Test both arguments together
+    with patch("sys.argv", ["prog", "--no-run-browser", "--no-reloader"]):
+        gui = Gui()
+        gui.run(run_server=False, run_browser=True, use_reloader=True)
+        service_config = gui._config.config
+        assert not service_config["run_browser"]
+        assert not service_config["use_reloader"]
+        gui.stop()
+
+    # Test CLI arguments override TOML configuration
+    toml_config = NamedTemporaryFile(
+        content="""
+[TAIPY]
+
+[gui]
+run_browser = "true:bool"
+use_reloader = "true:bool"
+    """
+    )
+    Config.load(toml_config.filename)
+
+    with patch("sys.argv", ["prog", "--no-run-browser", "--no-reloader"]):
+        gui = Gui()
+        gui.run(run_server=False)
+        service_config = gui._config.config
+        assert not service_config["run_browser"]
+        assert not service_config["use_reloader"]
+        gui.stop()
+
+    # Test CLI arguments override Config.configure_gui()
+    Config.configure_gui(run_browser=True, use_reloader=True)
+
+    with patch("sys.argv", ["prog", "--no-run-browser", "--no-reloader"]):
+        gui = Gui()
+        gui.run(run_server=False)
+        service_config = gui._config.config
+        assert not service_config["run_browser"]
+        assert not service_config["use_reloader"]
+        gui.stop()
+
+    # Test precedence: CLI > TOML > Config.configure_gui() > Gui.run()
+    toml_config_2 = NamedTemporaryFile(
+        content="""
+[TAIPY]
+
+[gui]
+run_browser = "true:bool"
+use_reloader = "false:bool"
+    """
+    )
+    Config.load(toml_config_2.filename)
+    Config.configure_gui(run_browser=False, use_reloader=True)
+
+    with patch("sys.argv", ["prog", "--no-run-browser"]):
+        gui = Gui()
+        gui.run(run_server=False, run_browser=True, use_reloader=False)
+        service_config = gui._config.config
+        assert not service_config["run_browser"]
+        assert service_config["use_reloader"]
+        gui.stop()
+
 def test_clean_config():
     gui_config = Config.configure_gui(dark_mode=False)